Skip to content

[TOOL-3485] Dashboard: Improve USD currency formatting #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

[TOOL-3485] Dashboard: Improve USD currency formatting #6304

merged 1 commit into from
Feb 20, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 20, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the formatting of monetary values across various components in the dashboard by introducing a utility function, toUSD, which standardizes the currency display.

Detailed summary

  • Added toUSD utility function for consistent currency formatting.
  • Replaced inline currency formatting with toUSD in:
    • PaymentsSuccessRate.tsx
    • Payouts.tsx
    • PayCustomersTable.tsx
    • TotalVolumePieChart.tsx
    • TotalSponsoredChartCard.tsx
  • Updated random value generation in storyUtils.ts to use non-integer values.
  • Modified number formatting logic in format-utils.ts to use a compact notation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 20, 2025

TOOL-3485 Limit decimal places to two in Gas Sponsor chart

@MananTank MananTank marked this pull request as ready for review February 20, 2025 19:45
@vercel
Copy link

vercel bot commented Feb 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:03pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:03pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:03pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:03pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:03pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 20, 2025
@MananTank MananTank requested review from a team as code owners February 20, 2025 19:45
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c2da5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank changed the title [TOOL-3485] Dashboard: Improved Currency formatting [TOOL-3485] Dashboard: Improve USD currency formatting Feb 20, 2025
@codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (846a5b5) to head (5c2da5f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6304   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5260     5260           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 846a5b5
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 162 ms (+51.26% 🔺) 1.1 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 299 ms (+18.27% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 44 ms (+238.16% 🔺) 156 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 19 ms (+565.73% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 97 ms (+219.05% 🔺) 483 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 20, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3485] Dashboard: Improve USD currency formatting (#6304)
5c2da5f 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the formatting of monetary values across various components by replacing manual formatting with a utility function `toUSD`. This enhances consistency and readability in displaying currency values.

### Detailed summary
- Added `toUSD` utility function for consistent currency formatting.
- Replaced manual currency formatting in `PaymentsSuccessRate.tsx`, `Payouts.tsx`, `PayCustomersTable.tsx`, `TotalVolumePieChart.tsx`, and `TotalSponsoredChartCard.tsx`.
- Modified random number generation in `storyUtils.ts` to use non-integer values.
- Updated `format-utils.ts` to use a new compact number formatter.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot merged commit 5c2da5f into main Feb 20, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3485 branch February 20, 2025 20:04
@vercel vercel bot temporarily deployed to Production – wallet-ui February 20, 2025 20:04 Inactive
@vercel vercel bot temporarily deployed to Production – login February 20, 2025 20:04 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 20, 2025 20:04 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 20, 2025 20:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls